Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch canary agents to hosted agents #377

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

carlh98
Copy link
Contributor

@carlh98 carlh98 commented Nov 15, 2023

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

fix: switch canary agents to hosted agents

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@carlh98 carlh98 requested a review from a team November 15, 2023 20:17
@Soap-141
Copy link
Contributor

Soap-141 commented Nov 15, 2023

Should we add it in the changelog? Also that may apply as a None impact on version? @jeanplevesque also mentioned that ci should be the .github folder but this isn't, is it a fix?

@carlh98 carlh98 changed the title ci: switch canary agents to hosted agents fix: switch canary agents to hosted agents Nov 16, 2023
@carlh98 carlh98 requested review from jeanplevesque and a team November 16, 2023 01:15
@carlh98 carlh98 merged commit f69a3e4 into main Nov 16, 2023
14 checks passed
@carlh98 carlh98 deleted the dev/cama/UpdateCI branch November 16, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants