Sass enhancement #101
Merged
Sass enhancement #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jest-preview-library canceled.
|
nvh95
reviewed
May 3, 2022
ntt261298
force-pushed
the
sass-enhancement
branch
2 times, most recently
from
b6e4153 to
2d68857
Compare
nvh95
reviewed
May 21, 2022
There was a problem hiding this comment.
@ntt261298 I think this PR is good for now. Can you help to update the docs so we can merge this PR. The update on website is optional, I can help with that if you want.
And please help to rebase this PR after #102 get merged.
Please update the PR description to add any of your concerns that we should handle in the future PR (global externalCSS ~?)
|
@ntt261298 I think we should try to close this PR soon. Thanks. |
ntt261298
force-pushed
the
sass-enhancement
branch
from
c8e19fa to
a375a11
Compare
nvh95
approved these changes
May 27, 2022
|
@ntt261298 I published v0.2.4-alpha.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Features
loadPathsfor SASS: Now we can add custom directories to indicate where SASS should lookup to resolve the absolute importsimport ~for SASS: Nowjest-previewcan load SASS resources if the project is using tilde imports for SASSload pathsandimport ~for Viteload pathsandimport ~for CRATodo
importerto sass CLI: https://sass-lang.com/documentation/cli/dart-sass#options. So ifexternalCssincludes scss files using import ~, style from those files will not work