Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for search_paths option #194

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Conversation

defr0std
Copy link
Contributor

Hi,

Thanks for the great plugin!

This is a proposed fix for #184. Currently, spectre always searches in the cwd, it launches the job with a given cwd and then passes . to the search tool.

Unfortunately, this does not work for large directories, such as monorepos. In a monorepo, you usually work in a number of different directories depending on the current project. So it is convenient to search in the scope of those directories.

Note that the path option in the spectre does not solve the issue. The search is still performed in the cwd, but only the files matched by the path glob are used for searching. But the search tool still needs to list the files recursively in the entire monorepo, which is very slow.

This PR adds another option to the configuration called search_paths. The search paths are then passed to the search tool, instead of the ..

Also need to fix the opening of the file. When searched like this, the returned file paths could be absolute, so we don't need to make a relative path to the cwd.

@EpsilonKu
Copy link
Member

Can you add to README?

@defr0std
Copy link
Contributor Author

Done, please take a look.

@EpsilonKu
Copy link
Member

You put Search paths inside config code.

@defr0std
Copy link
Contributor Author

But cwd option is not in config, and search paths option is similar to cwd.

@EpsilonKu
Copy link
Member

I mean this:
image
What about to put it outside of code block?

@defr0std
Copy link
Contributor Author

Oh, sorry, done :)

@EpsilonKu
Copy link
Member

LGTM

@EpsilonKu EpsilonKu merged commit 81cb399 into nvim-pack:master Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants