Add support for search_paths option #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the great plugin!
This is a proposed fix for #184. Currently, spectre always searches in the
cwd
, it launches the job with a givencwd
and then passes.
to the search tool.Unfortunately, this does not work for large directories, such as monorepos. In a monorepo, you usually work in a number of different directories depending on the current project. So it is convenient to search in the scope of those directories.
Note that the
path
option in the spectre does not solve the issue. The search is still performed in thecwd
, but only the files matched by thepath
glob are used for searching. But the search tool still needs to list the files recursively in the entire monorepo, which is very slow.This PR adds another option to the configuration called
search_paths
. The search paths are then passed to the search tool, instead of the.
.Also need to fix the opening of the file. When searched like this, the returned file paths could be absolute, so we don't need to make a relative path to the
cwd
.