feat: config to silence executable warnings #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on macOS and, although the
sed
on my path is GNU sed, I still see the "You need to install gnu sed 'brew install gnu-sed'" warning. This is because the plugin assumes macOS users will be using the Homebrew package manager and thus checks for thegsed
executable. While this is a safe assumption for many (most?) macOS users, folks who are using other package managers, have aliasedsed
togsed
, etc. will see false positives.I worked around this in a rather simple way, by adding a
warn
option that the user can simply set to false if they know better than the plugin. From the doc update:A medium-confidence check for GNU sed, e.g. testing for the existence of the
--version
flag, could be employed but that adds some execution overhead and a bit more complexity than the solution I'm proposing. Thoughts?