fix: nil problem when jump to location when tab drop is set as jump_type
#2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, you're able to use `tab drop` as `jump_type` for these LSP features: references, type definitions, definitions an implementations.
jamestrew
approved these changes
Nov 6, 2023
rameshsanth
pushed a commit
to rameshsanth/telescope.nvim
that referenced
this pull request
Nov 17, 2023
…p_type` (nvim-telescope#2760) * feat(lsp_definitions): adding `tab drop` as `jump_type` * feat(lsp-jump-types): `tab drop` for LSP features Now, you're able to use `tab drop` as `jump_type` for these LSP features: references, type definitions, definitions an implementations. * fix(docs): reordering `tab drop` option * feat: generate docs * fix: nil problem with `vim.uri_to_fname` * fix: removing warning about `file_uri` variable not being used --------- Co-authored-by: Simon Hauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recently implemented a feature to add
tab_dropasjump_typeoption for some LSP pickers in Telescope. I tested in two programming languages (Python and Go) and it worked fine. Today, I tried to write some Rust code and I was not able to use the "Go to definition" feature fromnvim-lspconfigdue to problems withnilwhen trying to jump to the location.That was being caused the file path (
flattened_results[1].uri) being passed in the methodvim.uri_to_fnamewas nil. That got me confuse because it works really well with Python (pyright) and Go (gopls), but not in Rust (rust-analyzer). After that, I realized that there is another attribute calledtargetUri(flattened_results[1].targetUri) that represents the target URI (as the name says). I tried to replaceurifortargetUriand it worked well with Rust, but Go and Python didn't accept it and the nil problem came back now with Python and Go.Therefore, I making that PR for addressing this issue and now it is working fine with all the languages that I tested (Dart with
dartls, Go withgopls, Python withpyright, Rust withrust-analyzerand C++ withclangd)Type of change
How Has This Been Tested?
dartls, Go withgopls, Python withpyright, Rust withrust-analyzerand C++ withclangd.Configuration:
Neovim version (nvim --version):
Operating system and version:
Checklist: