Fix some issues with builtin.colorscheme #3244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of issues I found with the current implementation of
builtin.colorscheme
. Currently two problems can be observed:enable_preview
is false. Shifting the selection behaves as expected however.enable_preview
is set to true.The code is modified to fix these issues.
Type of change
How Has This Been Tested?
1. Run
:Telescope colorscheme enable_preview=false
2. Start searching for something
3. Note that the color scheme is not changed until the enter key is pressed
1. Run
:Telescope colorscheme enable_preview=true
2. Use the mouse to click on one of the options
3. Observe that the color scheme is changed
4. Exit Telescope and the original color scheme should be restored
Configuration:
Checklist: