Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization UI #290

Merged
merged 9 commits into from
Dec 22, 2024
Merged

Normalization UI #290

merged 9 commits into from
Dec 22, 2024

Conversation

tdanielles
Copy link
Contributor

@tdanielles tdanielles commented Dec 18, 2024

Description

Ticket: https://www.notion.so/nwplus/normalization-Add-new-UI-components-14c14d529faa8018b591e555d9d81480?pvs=4

  • added component CalcZScoreButton; the normalization function isn't in here anywhere yet
  • added the ff new APPLICANT_STATUSES: gradinginprog, ungraded, and scored:
    • scored: if all required fields to score exist and have a value
    • gradinginprog: if one or more fields exist and have a value but not all
    • ungraded: if none of the fields exist/score doesn't exist
  • made bg color of gradinginprog gray as specified by figma file
  • added verification modal when calculating z-scores
  • added verification modal when changing a score for a question that was previously graded by someone else
  • display prev total z-score on completely graded apps (i think this would only get updated when the big calczscorebutton is clicked again?) on HackerEntry and Scoring components
  • added total z-score filter for acceptances

Copy link

github-actions bot commented Dec 18, 2024

Visit the preview URL for this PR (updated for commit b58f2ed):

https://nw-admin-portal--pr290-trisha-normalization-j4wxh0tm.web.app

(expires Thu, 26 Dec 2024 03:43:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

@tdanielles tdanielles marked this pull request as ready for review December 19, 2024 03:43
Copy link
Member

@DonaldKLee DonaldKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DonaldKLee DonaldKLee merged commit b9d1f0f into dev Dec 22, 2024
5 checks passed
@DonaldKLee DonaldKLee deleted the trisha/normalization-ui branch December 22, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants