Fix getVersion returning an undefined version (#347)

nwutils · Jul 30, 2016 · ff97d78 · ff97d78
1 parent 13767ed
commit ff97d78
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/lib/versions.js b/lib/versions.js
@@ -158,16 +158,13 @@ module.exports = {
     getVersion: function(args){
         return (isLegacyVersion(args.desiredVersion) ? getLegacyVersions : getVersionsFromManifest)(args.downloadUrl)
             .then(function(versions) {
-                var version = versions.find(function(version){
-                    if(version.version === args.desiredVersion) {
-                        return version;
-                    }
+                var version = versions.findIndex(function(version){
+                    return version.version === args.desiredVersion;
                 });
 
-                if(version){
-                    return version;
-                }
-                throw new Error('Version ' + args.desiredVersion + ' not found.');
+                return version >= 0
+                    ? Promise.resolve(versions[version])
+                    : Promise.reject('Version ' + args.desiredVersion + ' not found.');
             });
     },
     /**