ASoC: fsl_esai: restore DAI format constants #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch "MLK-19750-1: ASoC: fsl_esai: enhance async mode (part 1)", reverted the constants to their old naming and replaced with and used the wrong values: https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/include/sound/soc-dai.h#L127-L131 This results in the error: root@imx8qm-var-som:~# aplay /usr/share/sounds/alsa/Front_Center.wav [ 21.241657] fsl-esai-dai 59010000.esai: failed to derive required SCKT rate [ 21.248673] fsl-esai-dai 59010000.esai: ASoC: error at snd_soc_dai_hw_params on 59010000.esai: -22 [ 21.257795] HiFi: ASoC: error at __soc_pcm_hw_params on HiFi: -22 ALSA lib /usr/src/debug/alsa-lib/1.2.8-r0/src/pcm/pcm_direct.c:1336:(snd1_pcm_direct_initialize_slave) unable to install hw params ALSA lib /usr/src/debug/alsa-lib/1.2.8-r0/src/pcm/pcm_dmix.c:1011:(snd_pcm_dmix_open) unable to initialize slave aplay: main:831: audio open error: Invalid argument This patch restores the original constants. fixes: nxp-imx@8734e7f Signed-off-by: Nate Drude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch "MLK-19750-1: ASoC: fsl_esai: enhance async mode (part 1)", reverted the constants to their old naming and replaced with and used the wrong values: https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/include/sound/soc-dai.h#L127-L131
This results in the error:
root@imx8qm-var-som:~# aplay /usr/share/sounds/alsa/Front_Center.wav
[ 21.241657] fsl-esai-dai 59010000.esai: failed to derive required SCKT rate
[ 21.248673] fsl-esai-dai 59010000.esai: ASoC: error at snd_soc_dai_hw_params on 59010000.esai: -22
[ 21.257795] HiFi: ASoC: error at __soc_pcm_hw_params on HiFi: -22
ALSA lib /usr/src/debug/alsa-lib/1.2.8-r0/src/pcm/pcm_direct.c:1336:(snd1_pcm_direct_initialize_slave) unable to install hw params
ALSA lib /usr/src/debug/alsa-lib/1.2.8-r0/src/pcm/pcm_dmix.c:1011:(snd_pcm_dmix_open) unable to initialize slave
aplay: main:831: audio open error: Invalid argument
This patch restores the original constants.
fixes: 8734e7f