Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nxp-wlan-sdk_git.inc to use correct branch #10

Open
wants to merge 1 commit into
base: zeus-5.4.24-2.1.0
Choose a base branch
from

Conversation

drumilmahajan
Copy link

This change updates the nxp-wlan-sdk_git.inc file to use the branch of mwifiex that is meant for 5.4 kernel versions and not the master branch to fix compilation errors that are addressed in 5.4.24.xx branch

This change updates the nxp-wlan-sdk_git.inc file to use the branch of mwifiex that is meant for 5.4 kernel versions and not the master branch to fix compilation errors that are addressed in 5.4.24.xx branch
@drumilmahajan
Copy link
Author

@thochstein Do the PRs automatically get reviewed by someone on this project or does it require that I tag one of the maintainers?

@thochstein thochstein requested a review from junzhuimx May 5, 2023 20:03
@junzhuimx
Copy link
Contributor

@drumilmahajan
The original commit is pointed to 5.4.24-2.1.0 release -- https://github.com/nxp-imx/mwifiex/commits/rel_imx_5.4.24_2.1.0
Please clarify whether BSP release you are used and what build break you meet.

@drumilmahajan
Copy link
Author

@junzhuimx I used zeus BSP and the recipe pointed initially to the master branch and the compilation was breaking on the mwifi code. The source code itself had compilation issues which were addressed in the 5.4.24.xx branch of the mwifix source code. So my commit instead of pointing it to the master branch, points it to the 5.4.24.xx branch where the compilation error in the source code has been fixed.

If you look at the last two commits on https://github.com/nxp-imx/mwifiex/commits/imx_5.4.70_2.3.0 , they fix a yocto compilation error which is not fixed on master branch. So I am making the recipe point to the correct branch which has the fix.

Let me know if you have more questions :)

@drumilmahajan
Copy link
Author

@junzhuimx any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants