Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory corruption in libuuu fastboot #459

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

tjaros
Copy link
Contributor

@tjaros tjaros commented Feb 26, 2025

This PR addresses the issue of memory corruption observed when using the Python binding for libuuu on Mac OS X Apple Silicon. The problem was identified in the FastBoot::Transport method, where the response buffer was not properly null-terminated.

Changes Made:

  1. Null-Termination: Added a line to ensure that the response buffer is null-terminated after reading data from the transport layer.
  2. Updated Dependencies & Configuration: Adjusted dependency pinning for setuptools_scm and added automatedly generated __version__.py file into ignore list for isort tool

Testing:

The fix was tested on Mac OS X Apple Silicon, Ubuntu and Windows 11, confirming that the issue is resolved on macOS while maintaining functionality on other platforms.

References:

Copy link
Contributor

@nxpfrankli nxpfrankli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Signed-off-by: tag in commit message

@tjaros
Copy link
Contributor Author

tjaros commented Feb 27, 2025

Please add Signed-off-by: tag in commit message

Done.

@tjaros
Copy link
Contributor Author

tjaros commented Feb 27, 2025

Might need to investigate a bit more, cause suddenly the pipeline started failing. I'll let you know when that is done.

@tjaros tjaros force-pushed the master branch 5 times, most recently from a506bfd to b30f8cb Compare February 27, 2025 13:44
@nxpfrankli nxpfrankli merged commit 0525e50 into nxp-imx:master Feb 27, 2025
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants