Adding progress block for download operations #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix spelling in README
| @@ -116,6 +117,24 @@ - (void)performRequestWithSendingProgressHandler:(NXOAuth2ConnectionSendingProgr | |||
| self.me = self; | |||
There was a problem hiding this comment.
This creates a retain cycle. The caller should be responsible for keeping a reference.
There was a problem hiding this comment.
I am just replicating the form of the existing method performRequestWithSendingProgressHandler. This reference is removed on closures methods such as cancel or oauthConnection:didFinishWithData:. Anyway I've just refactored that to make it more clear.
added 2 commits
March 10, 2015 15:46
This reverts commit 304fc37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am using this library and I miss some progress block for downloads request so I added it.