add headerFields dict property to NXOAuth2Request #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can add custom HTTP headers per request.
|
Any chance this can get merged in or we have some official support for setting header fields? It seems like many people need this support, as someone else added similar functionality #132. |
| { | ||
| for (id key in someHeaders) { | ||
| id value = someHeaders[key]; | ||
| if ([key isKindOfClass:[NSString class]] && [value isKindOfClass:[NSString class]]) { |
There was a problem hiding this comment.
This should be an NSAssert since not spacing this right is a programmer error. This fails silently which is dangerous.
|
Looks good. If you fix the one complaint we can absolutely merge this. |
|
Cool, have updated to use asserts |
toto
added a commit
that referenced
this pull request
Oct 15, 2015
add headerFields dict property to NXOAuth2Request
|
Thanks for the fast response! |
|
Sure :-) I will look into pushing a new version to Cocoapods next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can add custom HTTP headers per request.