Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Event OptIn ID #652

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Channel Event OptIn ID #652

merged 2 commits into from
Oct 4, 2023

Conversation

rowanseymour
Copy link
Member

  • RP backend now extracts optin id from extra and saves as actual id in the database
  • Change extra fields on optin/optout events to be more consistent with other FB/IG events
  • Enforce extra being map[string]string as this avoids problems if an event is spooled to JSON and reloaded (ints become floats)

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #652 (ceab9b0) into main (0786149) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   74.24%   74.32%   +0.07%     
==========================================
  Files          99       99              
  Lines       13147    13136      -11     
==========================================
+ Hits         9761     9763       +2     
+ Misses       2697     2685      -12     
+ Partials      689      688       -1     
Files Coverage Δ
backends/rapidpro/channel_event.go 50.86% <100.00%> (+2.68%) ⬆️
handlers/facebook_legacy/handler.go 84.37% <100.00%> (-0.22%) ⬇️
handlers/meta/handlers.go 84.76% <100.00%> (+0.12%) ⬆️
handlers/test.go 0.00% <ø> (ø)
responses.go 79.71% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour requested a review from norkans7 October 4, 2023 16:19
@rowanseymour rowanseymour merged commit 68a5508 into main Oct 4, 2023
7 checks passed
@rowanseymour rowanseymour deleted the event_optin_id branch October 4, 2023 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants