Add optin as field to channelevents #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
event_optin
branch
from
4002d23 to
b390bc6
Compare
rowanseymour
force-pushed
the
event_optin
branch
from
b390bc6 to
b47e99f
Compare
Codecov Report
@@ Coverage Diff @@
## main #4875 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 537 538 +1
Lines 25925 25931 +6
=========================================
+ Hits 25925 25931 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@rowanseymour I was wondering whether we should create an optin object when we receive an optin event referencing an optin we do not have? Currently I think the optin are created by the floweditor only |
|
In theory that can't happen... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading these from extra is a bit fragile and means we can't do
select_related. We haveMsg.optinso makes sense to haveChannelEvent.optin.Goes with nyaruka/courier#652 and nyaruka/mailroom#148