Support sending and receiving stickers for WAC and D3C #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkans7
force-pushed
the
support-WAC-stickers
branch
from
7e20fe4 to
1847a76
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
+ Coverage 74.57% 74.61% +0.03%
==========================================
Files 110 110
Lines 13280 13290 +10
==========================================
+ Hits 9904 9916 +12
+ Misses 2664 2662 -2
Partials 712 712 ☔ View full report in Codecov by Sentry. |
|
@norkans7 since this isn't a bug gonna hold off merging until after release |
rowanseymour
reviewed
Sep 4, 2023
handlers/dialog360/dialog360.go
Outdated
| @@ -621,7 +632,9 @@ func (h *handler) Send(ctx context.Context, msg courier.Msg, clog *courier.Chann | |||
|
|
|||
| } else if i < len(msg.Attachments()) && (len(qrs) == 0 || len(qrs) > 3) { | |||
| attType, attURL := handlers.SplitAttachment(msg.Attachments()[i]) | |||
| attType = strings.Split(attType, "/")[0] | |||
| splitedAttType := strings.Split(attType, "/") | |||
There was a problem hiding this comment.
@norkans7 how about we rework this to call resolve media and then we can also check that the image is 512 x 512 ?
There was a problem hiding this comment.
Okay, I'll update that
norkans7
force-pushed
the
support-WAC-stickers
branch
from
1847a76 to
fd6068d
Compare
|
contains #624 |
norkans7
force-pushed
the
support-WAC-stickers
branch
from
fd6068d to
ef2015f
Compare
norkans7
force-pushed
the
support-WAC-stickers
branch
from
ef2015f to
dc47057
Compare
… for media support config
|
This branch is out of date I will rework on that again |
norkans7
force-pushed
the
support-WAC-stickers
branch
from
dc47057 to
ba7fa36
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to send and receive stickers as documented on https://developers.facebook.com/docs/whatsapp/cloud-api/reference/media#supported-media-types
The file need to be for format
image/webpand size less than 100KB or 500KB for animated one with dimensions not exceeding 512x512