Simplify metrics reporting #817
Conversation
|
|
||
| hostDim := cwatch.Dimension("Host", b.config.InstanceID) | ||
| appDim := cwatch.Dimension("App", "courier") |
There was a problem hiding this comment.
since the namespace is Temba/Courier app doesn't make sense as a dimension.. can update mailroom to match this
| s.Backend().CloudWatch().Queue( | ||
| cwatch.Datum("EventReceive", float64(secondDuration), types.StandardUnitSeconds, channelTypeDim), | ||
| ) | ||
| cw.Queue(cwatch.Datum("EventReceive", float64(secondDuration), types.StandardUnitSeconds, channelTypeDim)) |
There was a problem hiding this comment.
Not sure about any of these metrics... they're all measuring the overall handler time.. but if a handler produces multiple events/messages... the same data is reported multiple times.
Seems like we want a single handler latency metric? @ericnewcomer @norkans7
There was a problem hiding this comment.
Discussed with @ericnewcomer and we're gonna try turning these into counts that are reported each minute in the backend heartbeat
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
+ Coverage 74.54% 74.55% +0.01%
==========================================
Files 111 111
Lines 13267 13250 -17
==========================================
- Hits 9890 9879 -11
+ Misses 2659 2653 -6
Partials 718 718 ☔ View full report in Codecov by Sentry. |
rowanseymour
force-pushed
the
metrics_redux
branch
from
7654c96 to
82a458b
Compare
No description provided.