Merge pull request #1256 from nyaruka/set_run_result_limits

Make char limits on result name and category on `set_run_result` actions consistent with routers
nyaruka · Dec 2, 2024 · 2c8fa3e · 2c8fa3e
2 parents 3adaf44 + cad83f7
commit 2c8fa3e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/components/flow/actions/setrunresult/SetRunResultForm.tsx b/src/components/flow/actions/setrunresult/SetRunResultForm.tsx
@@ -112,6 +112,9 @@ export default class SetRunResultForm extends React.PureComponent<
   }
 
   private handleCreateAssetFromInput(input: string): Asset {
+    // workaround for the lack of a length limit on the form itself
+    input = input.substring(0, 64);
+
     return {
       id: snakify(input),
       name: input,
@@ -173,7 +176,7 @@ export default class SetRunResultForm extends React.PureComponent<
             onChange={this.handleCategoryUpdate}
             entry={this.state.category}
             autocomplete={false}
-            maxLength={128}
+            maxLength={36}
             helpText={i18n.t(
               'forms.result_category_help',
               "An optional category for your result. For age, the value might be 17, but the category might be 'Young Adult'"

diff --git a/src/components/flow/actions/setrunresult/__snapshots__/SetRunResultForm.test.ts.snap b/src/components/flow/actions/setrunresult/__snapshots__/SetRunResultForm.test.ts.snap
@@ -94,7 +94,7 @@ exports[`SetRunResultForm render should render 1`] = `
         }
       }
       helpText="An optional category for your result. For age, the value might be 17, but the category might be 'Young Adult'"
-      maxLength={128}
+      maxLength={36}
       name="Category"
       onChange={[Function]}
       placeholder="Optional"