Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make body optional on open ticket actions #1214

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Jan 3, 2024

Captura de pantalla 2024-01-03 a la(s) 17 00 51

@ericnewcomer how do you feel about getting rid of @results as the default?

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a17ab1) 64.15% compared to head (04be869) 64.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   64.15%   64.15%           
=======================================
  Files         181      181           
  Lines        7080     7080           
  Branches     1670     1670           
=======================================
  Hits         4542     4542           
  Misses       1964     1964           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericnewcomer ericnewcomer merged commit 92d6a68 into main Jan 4, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
@ericnewcomer ericnewcomer deleted the ticket_body_optional branch January 4, 2024 02:04
@rowanseymour
Copy link
Member Author

@ericnewcomer I tried getting rid of subject but got lost in React weirdness and figured I'd leave it as is

@ericnewcomer
Copy link
Member

I'd love this all be web components now, but zero chance that is ever happening.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants