Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display body as note on open ticket action #1244

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

rowanseymour
Copy link
Member

And remove subject. Flow definition remains as body for now.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.52%. Comparing base (263a378) to head (af763b0).

Files Patch % Lines
...omponents/flow/routers/ticket/TicketRouterForm.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
- Coverage   64.54%   64.52%   -0.02%     
==========================================
  Files         181      181              
  Lines        7087     7087              
  Branches     1677     1677              
==========================================
- Hits         4574     4573       -1     
- Misses       1934     1935       +1     
  Partials      579      579              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

let resultName = { value: 'Result' };
let assignee: FormEntry = { value: null };
let topic: FormEntry = { value: null };

if (getType(settings.originalNode) === Types.split_by_ticket) {
const action = getOriginalAction(settings) as OpenTicket;
subject = { value: action.subject };
body = { value: action.body };
note = { value: action.body };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still body in flow def

@rowanseymour rowanseymour merged commit c36930a into main Aug 8, 2024
5 of 6 checks passed
@rowanseymour rowanseymour deleted the body_to_note branch August 8, 2024 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant