Skip to content

Commit

Permalink
Expression error shouldn't prevent add urn action (e.g. email that lo…
Browse files Browse the repository at this point in the history
…oks like expression)
  • Loading branch information
rowanseymour committed Mar 16, 2018
1 parent cda1840 commit 29750e4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions flows/actions/add_contact_urn.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,9 @@ func (a *AddContactURNAction) Execute(run flows.FlowRun, step flows.Step, log fl

evaluatedPath, err := excellent.EvaluateTemplateAsString(run.Environment(), run.Context(), a.Path, false)

// if we received an error, log it
// if we received an error, log it although it might just be a non-expression like [email protected]
if err != nil {
log.Add(events.NewErrorEvent(err))
return nil
}

// if we don't have a valid URN, log error
Expand Down

0 comments on commit 29750e4

Please sign in to comment.