Remove deprecated collation alias

nyaruka · Sep 26, 2023 · 2c03e83 · 2c03e83
1 parent e079ee1
commit 2c03e83
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/envs/collate.go b/envs/collate.go
@@ -13,7 +13,6 @@ const (
 	CollationDefault        Collation = "default"
 	CollationConfusables    Collation = "confusables"
 	CollationArabicVariants Collation = "arabic_variants"
-	CollationArabicFarsi    Collation = "arabic_farsi" // deprecated alias
 )
 
 type collateTransformer func(string) string
@@ -54,9 +53,6 @@ var transformers = map[Collation]collateTransformer{
 	CollationConfusables: func(s string) string {
 		return strings.ToLower(stringsx.Skeleton(s))
 	},
-	CollationArabicFarsi: func(s string) string {
-		return strings.ToLower(replaceRunes(norm.NFKD.String(s), arabicVariants))
-	},
 	CollationArabicVariants: func(s string) string {
 		return strings.ToLower(replaceRunes(norm.NFKD.String(s), arabicVariants))
 	},

diff --git a/envs/collate_test.go b/envs/collate_test.go
@@ -25,11 +25,6 @@ func TestCollation(t *testing.T) {
 			"Nyaruka": true,
 			"𝒩ɣaruka": true,
 		}},
-		{envs.CollationArabicFarsi, "٠١٢٣٤٥٦۷٨٩", "۰۱۲۳۴۵۶۷۸۹", map[string]bool{
-			"٤٥٦۷":       false,
-			"٠١٢٣٤٥٦۷٨٩": true,
-			"۰۱۲۳۴۵۶۷۸۹": true,
-		}},
 		{envs.CollationArabicVariants, "٠١٢٣٤٥٦۷٨٩", "۰۱۲۳۴۵۶۷۸۹", map[string]bool{
 			"٤٥٦۷":       false,
 			"٠١٢٣٤٥٦۷٨٩": true,

diff --git a/flows/routers/cases/tests_test.go b/flows/routers/cases/tests_test.go
@@ -41,7 +41,7 @@ var dmy = envs.NewBuilder().
 	WithDefaultCountry(i18n.Country("RW")).
 	Build()
 var ara = envs.NewBuilder().
-	WithInputCollation(envs.CollationArabicFarsi).
+	WithInputCollation(envs.CollationArabicVariants).
 	Build()
 
 var assetsJSON = `{