Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only generate run_result_changed event when value or category changes #1291

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

@rowanseymour rowanseymour force-pushed the run_result_changed_only_when_changed branch from f0fd82d to df8ea10 Compare December 2, 2024 19:59
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.70%. Comparing base (a23f38d) to head (df8ea10).

Files with missing lines Patch % Lines
flows/events/run_result_changed.go 25.00% 5 Missing and 1 partial ⚠️
flows/results.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   81.72%   81.70%   -0.03%     
==========================================
  Files         276      276              
  Lines       21246    21261      +15     
==========================================
+ Hits        17364    17372       +8     
- Misses       3310     3316       +6     
- Partials      572      573       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 951316e into main Dec 2, 2024
5 of 7 checks passed
@rowanseymour rowanseymour deleted the run_result_changed_only_when_changed branch December 2, 2024 22:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant