Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require flow_type on queued flow start tasks #164

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

rowanseymour
Copy link
Member

It's redundant since we load the flow anyway when creating batches

@codecov-commenter
Copy link

Codecov Report

Merging #164 (c8a4ee0) into main (bc374bf) will increase coverage by 62.64%.
The diff coverage is 87.50%.

@@            Coverage Diff            @@
##           main     #164       +/-   ##
=========================================
+ Coverage      0   62.64%   +62.64%     
=========================================
  Files         0      147      +147     
  Lines         0    12302    +12302     
=========================================
+ Hits          0     7706     +7706     
- Misses        0     3761     +3761     
- Partials      0      835      +835     
Files Coverage Δ
core/models/starts.go 44.03% <100.00%> (ø)
core/tasks/handler/contact_tasks.go 49.30% <100.00%> (ø)
core/tasks/starts/start_flow.go 69.79% <50.00%> (ø)

... and 144 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit 46d6b2e into main Nov 2, 2023
5 checks passed
@rowanseymour rowanseymour deleted the schedule_rework_1 branch November 2, 2023 21:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants