Fix cloudwatch service stopping before tasks are stopped #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Dec 16, 2024
| mr.webserver.Stop() | ||
|
|
||
| mr.wg.Wait() | ||
|
|
||
| // now that all tasks are finished, stop services they depend on | ||
| mr.rt.CW.StopQueue() |
There was a problem hiding this comment.
this is now a blocking operation and that waits for its batcher to stop
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
=======================================
Coverage 62.27% 62.27%
=======================================
Files 195 195
Lines 13818 13818
=======================================
Hits 8605 8605
Misses 4301 4301
Partials 912 912 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.