Use cloudwatch #110
Merged
Use cloudwatch #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 61.11% 63.06% +1.94%
==========================================
Files 7 7
Lines 1304 1397 +93
==========================================
+ Hits 797 881 +84
- Misses 402 410 +8
- Partials 105 106 +1 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
use-cloudwatch
branch
2 times, most recently
from
4c2de9c to
5c71762
Compare
Merged
norkans7
force-pushed
the
use-cloudwatch
branch
from
16d1993 to
bade8ef
Compare
rowanseymour
requested changes
Dec 13, 2024
archives/archives.go
Outdated
| @@ -966,6 +968,19 @@ func ArchiveActiveOrgs(rt *runtime.Runtime) error { | |||
| timeTaken := dates.Now().Sub(start) | |||
| slog.Info("archiving of active orgs complete", "time_taken", timeTaken, "num_orgs", len(orgs)) | |||
|
|
|||
| rt.CW.Queue(types.MetricDatum{MetricName: aws.String("ArchiveElapsed"), Value: aws.Float64(timeTaken.Seconds()), Unit: types.StandardUnitSeconds}) | |||
There was a problem hiding this comment.
these are all sent once a night so we don't need to use the queue functionality .. see how it's done in indexer
norkans7
force-pushed
the
use-cloudwatch
branch
from
bade8ef to
9ebcca0
Compare
norkans7
force-pushed
the
use-cloudwatch
branch
3 times, most recently
from
0f85b80 to
207e8a1
Compare
archives/archives_test.go
Outdated
| ) | ||
|
|
||
| assert.NoError(t, err) | ||
| assert.Equal(t, 1, rt.CW.Client.(*cwatch.DevClient).CallCount()) |
There was a problem hiding this comment.
don't think we need this... this is testing gocommon not archiver
norkans7
force-pushed
the
use-cloudwatch
branch
from
207e8a1 to
6fb4183
Compare
norkans7
force-pushed
the
use-cloudwatch
branch
from
6fb4183 to
5701fd3
Compare
rowanseymour
requested changes
Dec 16, 2024
archives/archives_test.go
Outdated
|
|
||
| err := rt.CW.Send(ctx, | ||
| types.MetricDatum{MetricName: aws.String("NumGoats"), Value: aws.Float64(10), Unit: types.StandardUnitCount}, | ||
| types.MetricDatum{MetricName: aws.String("NumSheep"), Dimensions: []types.Dimension{{Name: aws.String("Host"), Value: aws.String("foo1")}}, Value: aws.Float64(20), Unit: types.StandardUnitCount}, |
There was a problem hiding this comment.
Still don't feel this belongs here.. it's like testing the DB connection. Running archiving will test that rt.CW.Send works as much as these lines.
norkans7
force-pushed
the
use-cloudwatch
branch
from
5701fd3 to
a88a45e
Compare
norkans7
force-pushed
the
use-cloudwatch
branch
from
a88a45e to
5dffbc3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.