Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending metrics #115

Merged
merged 1 commit into from
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion archives/archives.go
Original file line number Diff line number Diff line change
Expand Up @@ -984,9 +984,11 @@
cwatch.Datum("RollupsFailed", float64(totalRunsRollupsFailed), types.StandardUnitCount, runsDim),
}

ctx, cancel = context.WithTimeout(context.Background(), time.Minute)
if err = rt.CW.Send(ctx, metrics...); err != nil {
slog.Error("error putting metrics", "error", err)
slog.Error("error sending metrics", "error", err)

Check warning on line 989 in archives/archives.go

View check run for this annotation

Codecov / codecov/patch

archives/archives.go#L989

Added line #L989 was not covered by tests
}
cancel()

return nil
}
Loading