Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish switching to use slog for logging #92

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Finish switching to use slog for logging #92

merged 1 commit into from
Apr 12, 2024

Conversation

norkans7
Copy link
Contributor

@norkans7 norkans7 commented Oct 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 62.10%. Comparing base (c09fd50) to head (fac4f60).

❗ Current head fac4f60 differs from pull request most recent head 32e48d8. Consider uploading reports for the commit 32e48d8 to get more accurate results

Files Patch % Lines
cmd/rp-archiver/main.go 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   60.21%   62.10%   +1.89%     
==========================================
  Files           8        7       -1     
  Lines        1380     1338      -42     
==========================================
  Hits          831      831              
+ Misses        443      401      -42     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkans7 norkans7 changed the title Slog 2 Finish switching to use slog for logging Oct 13, 2023
@norkans7 norkans7 force-pushed the slog-2 branch 2 times, most recently from 57e0fc2 to fac4f60 Compare April 11, 2024 20:27
@norkans7 norkans7 marked this pull request as ready for review April 12, 2024 16:54
@rowanseymour rowanseymour merged commit b3f4220 into main Apr 12, 2024
5 checks passed
@rowanseymour rowanseymour deleted the slog-2 branch April 12, 2024 19:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants