Fix parsing of Number arrays (#503)

* Deseralize value from JSON not the index Credits to @victorigualada Co-Authored-By: victorigualada <[email protected]> * Fix tests to match change Co-Authored-By: victorigualada <[email protected]> * Update CHANGELOG.md --------- Co-authored-by: victorigualada <[email protected]>
nylas · Nov 21, 2023 · 182e6cc · 182e6cc
1 parent cb42d16
commit 182e6cc
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+### Unreleased
+* Fix parsing of Number arrays
+
 ### 6.10.0 / 2023-04-04
 * Add support for verifying webhook signatures
 

diff --git a/__tests__/calendar-restful-model-collection-spec.js b/__tests__/calendar-restful-model-collection-spec.js
@@ -169,7 +169,7 @@ describe('CalendarRestfulModelCollection', () => {
         openHours: [
           {
             emails: ['[email protected]'],
-            days: [Days.Sunday],
+            days: [Days.Sunday, Days.Thursday],
             timezone: 'America/Chicago',
             start: '10:00',
             end: '14:00',
@@ -200,7 +200,7 @@ describe('CalendarRestfulModelCollection', () => {
           open_hours: [
             {
               emails: ['[email protected]'],
-              days: [0],
+              days: [6, 3],
               timezone: 'America/Chicago',
               start: '10:00',
               end: '14:00',
@@ -306,7 +306,7 @@ describe('CalendarRestfulModelCollection', () => {
             open_hours: [
               {
                 emails: ['[email protected]', '[email protected]'],
-                days: [0],
+                days: [6],
                 timezone: 'America/Chicago',
                 start: '10:00',
                 end: '14:00',

diff --git a/src/models/attributes.ts b/src/models/attributes.ts
@@ -113,8 +113,8 @@ class AttributeNumberList extends Attribute {
     }
     const nums = [];
     for (const num in json) {
-      if (!isNaN(Number(num))) {
-        nums.push(Number(num));
+      if (!isNaN(Number(json[num]))) {
+        nums.push(Number(json[num]));
       }
     }
     return nums;