Skip to content

Commit

Permalink
v6.11.0 Release (#510)
Browse files Browse the repository at this point in the history
# Changelog
* Add support for logging (#508, #456)
* Nullify replyToMessageId is an empty string (#484, #509)
* Nullify visibility if visibility is an empty string (#507, #470)
* Fix numbers defaulting to 0 instead of null (#469)
* Fix parsing of Number arrays (#503, #502)
* Fix configured timeout not being used (#506, #489)
* Bump `node-fetch` dependency from 2.6.1 to 2.6.12 (#504, #496)
  • Loading branch information
mrashed-dev authored Nov 29, 2023
1 parent 9747bfa commit a28e120
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 6 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Changelog

### Unreleased
### 6.11.0 / 2023-11-28
* Add support for logging
* Nullify replyToMessageId is an empty string
* Nullify visibility if visibility is an empty string
* Fix numbers defaulting to 0 instead of null
* Fix parsing of Number arrays
* Fix configured timeout not being used
* Bump `node-fetch` dependency from 2.6.1 to 2.6.12
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ For more information about how to use the Nylas Node SDK, [take a look at our qu

Please refer to [Contributing](Contributing.md) for information about how to make contributions to this project. We welcome questions, bug reports, and pull requests.

Taking part in Hacktoberfest 2023 (i.e. issue is tagged with `hacktoberfest`)? Read our [Nylas Hacktoberfest 2023 contribution guidelines](https://github.com/nylas-samples/nylas-hacktoberfest-2023/blob/main/readme.md).

## 📝 License

This project is licensed under the terms of the MIT license. Please refer to [LICENSE](LICENSE.txt) for the full terms.
Expand Down
31 changes: 31 additions & 0 deletions __tests__/draft-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,37 @@ describe('Draft', () => {
});
});
});

test('should set reply_to_message_id to undefined if set to an empty string', done => {
testContext.draft.replyToMessageId = '';
return testContext.draft.save().then(() => {
const options = testContext.connection.request.mock.calls[0][0];
expect(options.url.toString()).toEqual('https://api.nylas.com/drafts');
expect(options.method).toEqual('POST');
expect(JSON.parse(options.body)).toEqual({
to: [],
cc: [],
bcc: [],
from: [],
date: null,
body: undefined,
events: [],
unread: undefined,
snippet: undefined,
thread_id: undefined,
subject: undefined,
version: undefined,
folder: undefined,
starred: undefined,
labels: [],
file_ids: [],
headers: undefined,
reply_to: [],
reply_to_message_id: undefined,
});
done();
});
});
});

describe('send', () => {
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nylas",
"version": "6.10.0",
"version": "6.11.0",
"description": "A NodeJS wrapper for the Nylas REST API for email, contacts, and calendar.",
"main": "lib/nylas.js",
"types": "lib/nylas.d.ts",
Expand Down

0 comments on commit a28e120

Please sign in to comment.