Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event and webhook models #535

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Fix event and webhook models #535

merged 4 commits into from
Feb 9, 2024

Conversation

mrashed-dev
Copy link
Contributor

Description

This PR brings a couple of changes to the SDK models:

  • Event-related models: createdAt and updatedAt are now optional fields
  • Webhook-related models: callbackUrl renamed to webhookUrl to maintain consistency with the API

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@mrashed-dev mrashed-dev merged commit 7a33267 into main Feb 9, 2024
4 checks passed
@mrashed-dev mrashed-dev deleted the v7.0.0-fix-event-webhook-models branch February 9, 2024 17:08
@mrashed-dev mrashed-dev mentioned this pull request Feb 12, 2024
Merged
mrashed-dev added a commit that referenced this pull request Feb 12, 2024
@mrashed-dev
v7.1.0 Release (#538)
23dc941 
# Changelog
* Added support for `/v3/connect/tokeninfo` endpoint (#536)
* Models can now directly be imported from the top-level `nylas` package (#534)
* Fixed inaccuracies in event and webhook models (#535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yifanplanet yifanplanet yifanplanet approved these changes

@AaronDDM AaronDDM Awaiting requested review from AaronDDM

@relaxedtomato relaxedtomato Awaiting requested review from relaxedtomato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrashed-dev @yifanplanet