Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buffer support for file attachments #579

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Add buffer support for file attachments #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f9405b
add buffer as an accepted type
mrashed-dev Sep 27, 2024
67a0333
add clearer documentation
mrashed-dev Sep 27, 2024
9ff9529
Update CHANGELOG.md
mrashed-dev Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

### Unreleased
* Add support for filtering events by attendee email
* Add buffer support for file attachments
* Fix issue where crypto import was causing downstream Jest incompatibilities

### 7.5.2 / 2024-07-12
Expand Down
6 changes: 4 additions & 2 deletions src/models/attachments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ interface BaseAttachment {
export interface CreateAttachmentRequest extends BaseAttachment {
/**
* Content of the attachment.
* It can either be a readable stream or a base64 encoded string.
* It can either be a readable stream, a base64 encoded string, or a buffer.
* For attachments less than 3MB, the content can be a readable stream, or a base64 encoded string.
* For attachments greater than 3MB, the content must be either a readable stream or a buffer.
*/
content: NodeJS.ReadableStream | string;
content: NodeJS.ReadableStream | string | Buffer;
}

/**
Expand Down
Loading