NYS-159: Update event calendar JS to ensure new html 5 exposed filter form standards are met and calendar functionality is restored #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… form standards are met
|
Can you elaborate on how changing the format (and/or the JS-targeted classes) are affecting this? |
@routinet, high level, the views exposed form previously used a generic text input field for date filters (with no native HTML validations), which allowed some sloppy JS to work. But Drupal/views switched to using a HTML5 date picker by default, which enforces an input format of yyyy-MM-dd (ISO format). I'm not sure when views updated this field to use a proper HTML5 date picker, but I suspect this happened as part of the D10 upgrade (I'm not certain about that though--happy to look into the source of this further). |
routinet
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.