Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NYS-16492: public hearing updates not importing #218

Merged
merged 1 commit into from
Jul 23, 2024
Merged

NYS-16492: public hearing updates not importing #218

merged 1 commit into from
Jul 23, 2024

Conversation

routinet
Copy link
Contributor

  • Clean up usage of raw vs resolved command-line options
  • Implement OL API changes to public hearing returns
  • Address Drush's removal of success/fail constants
  • Clean up old sniffer canary (yay! it's working!)

@routinet
NYS-16492: public hearing updates not importing
e65cc5e 
  - Clean up usage of raw vs resolved command-line options
  - Implement OL API changes to public hearing returns
  - Address Drush's removal of success/fail constants
  - Clean up old sniffer canary (yay! it's working!)
joelsteidl
joelsteidl approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@joelsteidl joelsteidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issues with the changes. I followed up in Slack for a bit more context. I'm always happy to see the code sniffer upping the strictness of code.

@fksaintil fksaintil added the ready Tested and ready for deployment (unless on-hold) label Jul 23, 2024
@kzalewski kzalewski merged commit ae6cce5 into main Jul 23, 2024
1 check passed
@kzalewski kzalewski deleted the nys-16492--fix-public-hearing-update-imports branch July 23, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelsteidl joelsteidl joelsteidl approved these changes

@fksaintil fksaintil fksaintil approved these changes

@kzalewski kzalewski Awaiting requested review from kzalewski

@nathanielwoodland nathanielwoodland Awaiting requested review from nathanielwoodland

Assignees
No one assigned
Labels
ready Tested and ready for deployment (unless on-hold)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@routinet @joelsteidl @fksaintil @kzalewski