Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix voting widget on featured legislation #228

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Fix voting widget on featured legislation #228

merged 9 commits into from
Sep 9, 2024

Conversation

aheaphy
Copy link
Contributor

@aheaphy aheaphy commented Aug 21, 2024

for committee and senator microsite pages

@aheaphy aheaphy added the testing PR is current being tested label Aug 21, 2024
@aheaphy aheaphy requested review from nathanielwoodland and routinet and removed request for nathanielwoodland August 22, 2024 15:34
nathanielwoodland
nathanielwoodland approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@nathanielwoodland nathanielwoodland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this at a high level (with a couple suggestions that you can review), but I'm not very familiar with the work here, so let me know if you'd like me to pull this in locally for a closer evaluation.

web/themes/custom/nysenate_theme/nysenate_theme.theme Outdated Show resolved Hide resolved
web/themes/custom/nysenate_theme/nysenate_theme.theme Outdated Show resolved Hide resolved
...mes/custom/nysenate_theme/src/templates/paragraphs/paragraph--featured-legislation.html.twig Outdated Show resolved Hide resolved
@fksaintil fksaintil added ready Tested and ready for deployment (unless on-hold) and removed testing PR is current being tested labels Sep 9, 2024
@kzalewski kzalewski merged commit d381845 into main Sep 9, 2024
2 checks passed
@kzalewski kzalewski deleted the feature/nys-16572--bill-subscribe branch September 9, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielwoodland nathanielwoodland nathanielwoodland approved these changes

@routinet routinet routinet approved these changes

Assignees
No one assigned
Labels
ready Tested and ready for deployment (unless on-hold)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aheaphy @routinet @nathanielwoodland @kzalewski @fksaintil