Skip to content

Conversation

cv
Copy link

@cv cv commented Aug 22, 2025

Summary

  • Fixes Trashed documents show up on site #357 - Trashed documents were showing up in folder listings but not in search results
  • Added trashed = false filter to ensure consistency between search and list functionality
  • Prevents trashed documents from appearing on the site until permanently deleted

Changes

  • server/list.js: Added AND trashed = false to the query string in getOptions() function for folder drive type
  • test/unit/list.test.js: Added comprehensive tests to verify trashed documents are filtered for both team and folder drive types

Test Plan

  • Added unit tests for both team and folder drive types
  • All existing tests pass (115/119 - 4 pre-existing failures unrelated to this change)
  • Linter passes with no issues
  • Verified search functionality remains unchanged

🤖 Generated with Claude Code

Resolves nytimes#357 - Trashed documents no longer show up in folder listings

- Added 'trashed = false' filter to getOptions() in list.js for folder drive type
- Ensures consistency with search.js which already had this filter
- Added comprehensive tests to verify trashed documents are filtered

This fix prevents trashed documents from appearing on the site until they are
permanently deleted, matching the expected behavior from the Google Drive interface.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trashed documents show up on site
1 participant