Fix block marks #155
Open
Fix block marks #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had been leaving it up to the
NodeViewcomponent to render their ownMarkViews, if their node was not inline. This causes the view descriptor tree to be built incorrectly: the MarkViewDesc must be a parent of the NodeViewDesc, so the MarkView component must be a parent of the NodeView component.This PR moves the responsibility for rendering wrapping MarkViews into the ChildElement component, which is where we handle (much more complex) inline MarkView wrapping as well.