-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes: runtime filtering of measurements and selection of processing for simultaneous measurements #379
Conversation
Visit the preview URL for this PR (updated for commit 1ec99a9): https://nyx-rustdoc--pr379-feat-gh-333-od-msr-j-jlj40tik.web.app (expires Sun, 15 Dec 2024 15:32:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
Coverage now takes 8 min on my desktop, so I'm moving it to the normal workflow
Fixed by setting the default measurement noise to identity. Doppler and some rangeTo test, simply remove the Azimuth and Doppler |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
===========================================
- Coverage 76.29% 66.21% -10.09%
===========================================
Files 84 88 +4
Lines 13332 13406 +74
===========================================
- Hits 10172 8877 -1295
- Misses 3160 4529 +1369 ☔ View full report in Codecov by Sentry. |
With the code on master, the prefits are within the measurement noise bounds and running with range+doppler simultaneously or sequentially leads to very similar results.
Azimuth error is higher than elevation, which is higher than range, and which is higher than Doppler. Will try to improve
Residual ratios are still too optimistic as a denominator.
…tracker noises. Add sequential OD struct. Add error logs for incorrect filter config
Summary
Orbit determination measurements are no longer their own type. Instead, they're all part of the
Measurement
structure which can store multiple simultaneous measurements in a HashMap. All tracking devices are represented as a BTreeMap. All tracking data is also represented as a BTreeMap.This leads to significant code simplifications, along with runtime flexibility to enable or disable specific measurement types from specific ground stations (or trackers in general). This is an important requirement for operations where a specific measurement type by a given ground station may be unreliable.
Architectural Changes
Closes #333
New Features
Improvements
Bug Fixes
No change
Testing and validation
Documentation
This PR does not primarily deal with documentation changes.