Improve performance of ratings in JSON #954
Open
+51
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reid-rigo
commented
Feb 16, 2024
| class UpdateQueryUpdatedAtWithRatings < ActiveRecord::Migration[7.1] | ||
| def change | ||
| execute <<-SQL | ||
| UPDATE queries SET updated_at = GREATEST(updated_at, (SELECT MAX(updated_at) FROM ratings WHERE query_id = queries.id)) |
There was a problem hiding this comment.
Alternatively a new column could be added like ratings_updated_at
|
How about we go through this next Ruby Code Jam??? It hink it could be great! |
|
@reid-rigo could we jump on a zoom and go through this.. I think my understanding has finally caught up enough over the past year to have a reaosnable conversation about this PR! We recently moved a lot of stuff to allow Quepid to have a case with 5000 queries (previosu feasible limit was like 300 or 500) and so I suspect this could help with some of the remaining bottle necks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Case.includes(queries: :ratings)is a heavy operation for large cases.This optimizes JSON building with a method (
Case#doc_ratings_by_query) to load just the needed ratings columns in one shot.