Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DXSC tool to patch specialization constant on DXIL #4

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

akioCL
Copy link

@akioCL akioCL commented Jun 7, 2024

Add new command line tool to be able to patch DXIL blobs so they can be used with specialization constants on O3DE.
The tool finds shader options (marked as volatiles) and replace them with normal constants. It also saves the bit offsets to each of these shader options so they can be patched at runtime. The DXIL blob is signed after the patching.

Full approach detailed here https://godotengine.org/article/d3d12-adventures-in-shaderland/

Based on RFC o3de/sig-graphics-audio#163

Other relevant PRs:
o3de/o3de-azslc#88
o3de/o3de#18019

Copy link

@moudgils moudgils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to update the 3p package. I think the expected approach is to cut a new branch (release-1.7.2308-o3de.2) and then go through the process of creating a new 3p package. This process is much simpler now with Github actions.

Signed-off-by: Akio Gaule <[email protected]>
@akioCL akioCL merged commit 87f4e45 into release-1.7.2308-o3de.1 Jun 28, 2024
1 check passed
@akioCL akioCL deleted the specialization_constants branch June 28, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants