Fix a crash #86
Merged
Fix a crash #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bodies Signed-off-by: Vivien Oddou <[email protected]>
VickyAtAZ
approved these changes
Oct 10, 2023
moudgils
approved these changes
Oct 11, 2023
Signed-off-by: Vivien Oddou <[email protected]>
|
just version bump added after review. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in impact analysis caused by functions with no definition bodies.
This was discovered while working on shader management console, because of working with the latest version of standard PBR that has a late-user-implementation GetDepth function. No bodies are tolerated, so this PR fixes the fact that activating cost impact analysis makes azslc crash on them. This is not critical since the azslc binary that does that isn't live yet if I recall correctly.