Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend nic with mac #240

Merged
merged 11 commits into from
Nov 29, 2022
Merged

Extend nic with mac #240

merged 11 commits into from
Nov 29, 2022

Commits on Nov 4, 2022

  1. extend-nic-with-mac

    @Vatson112
    Vatson112 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    4a11ecf View commit details
    Browse the repository at this point in the history

  2. extend nicParams struct

    @Vatson112
    Vatson112 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    bff5634 View commit details
    Browse the repository at this point in the history

  3. extend nicParams struct

    @Vatson112
    Vatson112 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    ff63320 View commit details
    Browse the repository at this point in the history

  4. Add WithMac for NIC creation

    @Vatson112
    Vatson112 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5c43035 View commit details
    Browse the repository at this point in the history

  5. Add RO interface to MAC

    @Vatson112
    Vatson112 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    530ed58 View commit details
    Browse the repository at this point in the history

  6. fix err with empty mac

    @Vatson112
    Vatson112 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    495ea87 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. del test

    @Vatson112
    Vatson112 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    52c17cd View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. add NIC mac tests

    @Vatson112
    Vatson112 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    13c7726 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. add NIC create with mac test

    @Vatson112
    Vatson112 committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    71970ad View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. fix golangci-lint issue

    @Vatson112
    Vatson112 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    e52f997 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. fix nic creation without mac params 

    The additional empty string check on the mac param is required here. If the mac param is not set, a mac for the nic will be generated anyway when testing against a real oVirt engine - and cause this assert func to fail (for example in TestVMNICCreation)

Co-authored-by: Michael Engel <[email protected]>
    @Vatson112 @engelmi
    Vatson112 and engelmi authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    85b55e8 View commit details
    Browse the repository at this point in the history