fix: getQuery() may have undefined values #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kitsonk
reviewed
Nov 11, 2021
| @@ -25,18 +25,18 @@ export type GetParamsOptions = GetQueryOptionsBase | GetQueryOptionsAsMap; | |||
| export function getQuery( | |||
| ctx: Context | RouterContext, | |||
| options: GetQueryOptionsAsMap, | |||
| ): Map<string, string>; | |||
| ): Map<string, string | undefined>; | |||
There was a problem hiding this comment.
This is unnecessary, as Map is possibly undefined in strict mode already.
There was a problem hiding this comment.
But if we update the type of result to Record<string, string | undefined>, then the new Map(Object.entries(result)) will also return a value of Map<string, string | undefined>, which is not assignable to Map<string, string>.
| /** Given a context, return the `.request.url.searchParams` as a record object | ||
| * of keys and values of the params. */ | ||
| export function getQuery( | ||
| ctx: Context | RouterContext, | ||
| options?: GetQueryOptionsBase, | ||
| ): Record<string, string>; | ||
| ): Record<string, string | undefined>; |
There was a problem hiding this comment.
This is the only thing that needs possibly undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am using Deno to try to write a chatroom demo, and now I think I've encountered a problem. Here's an example code:
Here the VSCode just infers that the type of username is just string and wouldn't be undefined because the type of the return value of
getQuery()isRecord<string, string>. But in fact it sometimes does occur. And it also made me ignore considering the situation that the username would be empty so I didn't write the relevant code to check and avoid it. It may make debug hard so I just modified the type of the return value.