Update conversion script and add test

Signed-off-by: Rodolfo Olivieri <[email protected]>

.pylintrc

@@ -18,7 +18,9 @@ disable=
  consider-using-f-string,
  consider-using-with,
  unspecified-encoding,
- line-too-long
+ line-too-long,
+ # Temporary solution
+ duplicate-code
 
 [REPORTS]
 

scripts/conversion_script.py

@@ -386,12 +386,15 @@ def parse_migration_results():
     with open(C2R_MIGRATION_RESULTS_FILE) as handler:
         contents = json.load(handler)
 
-    activities = contents["activities"]
+    if not contents:
+        return False
+
+    activities = contents.get("activities", [{}])
     # Pick the latest run as it is the only one that matters for the decision
     # process.
     latest_run = activities[-1]
 
-    return latest_run["success"]
+    return latest_run.get("success", False)
 
 
 def update_insights_inventory():
@@ -428,7 +431,6 @@ def main():
         setup_convert2rhel(required_files)
         install_convert2rhel()
         run_convert2rhel()
-        update_insights_inventory()
 
         # Gather JSON & Textual report
         data = gather_json_report()
@@ -446,6 +448,7 @@ def main():
         # Insights.
         output.message = generate_report_message(migration_result, highest_level)
         output.entries = transform_raw_data(data)
+        update_insights_inventory()
         print("Conversion script finish successfully!")
     except ProcessError as exception:
         print(exception.report)

tests/conversion_script/test_migration_results.py

@@ -0,0 +1,56 @@
+import json
+from mock import patch
+import pytest
+from scripts.conversion_script import parse_migration_results
+
+
+def test_no_migration_results(tmpdir):
+    migration_result_file = tmpdir.join("migration_result")
+    with patch(
+        "scripts.conversion_script.C2R_MIGRATION_RESULTS_FILE",
+        str(migration_result_file),
+    ):
+        assert not parse_migration_results()
+
+
+@pytest.mark.parametrize(
+    ("content", "expected"),
+    (
+        (
+            {"activities": [{"success": True}]},
+            True,
+        ),
+        (
+            {"activities": [{"success": False}]},
+            False,
+        ),
+        (
+            {"activities": [{"success": False}, {"success": True}]},
+            True,
+        ),
+        (
+            {"activities": [{"success": True}, {"success": False}]},
+            False,
+        ),
+        (
+            {"activities": [{}]},
+            False,
+        ),
+        (
+            {},
+            False,
+        ),
+        (
+            None,
+            False,
+        ),
+    ),
+)
+def test_migration_results_content(content, expected, tmpdir):
+    migration_result_file = tmpdir.join("migration_result")
+    migration_result_file.write(json.dumps(content, indent=4))
+    with patch(
+        "scripts.conversion_script.C2R_MIGRATION_RESULTS_FILE",
+        str(migration_result_file),
+    ):
+        assert parse_migration_results() == expected