Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup c2r pkg correctly #37

Merged
merged 11 commits into from
Nov 27, 2023
Merged

Conversation

andywaltlova
Copy link
Collaborator

@andywaltlova andywaltlova commented Nov 21, 2023

HMS-3086

  • cleanup after pre-conversion
    • for both fails and successes - if convert2rhel existed on system before pkg is kept on system (update of the pkg is not rolled back), else cleaned up
  • cleanup after conversion
    • for fails - if convert2rhel existed on system before pkg is kept on system (update of the pkg is not rolled back), else cleaned up
    • for successes - pkg is always kept because of statistics with the note that this can be removed after we do not rely on that fact

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b96685) 100.00% compared to head (13a302f) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          351       382   +31     
=========================================
+ Hits           351       382   +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andywaltlova andywaltlova marked this pull request as ready for review November 23, 2023 11:12
Once we are not reliant on the installed RPM for statistical purposes on insights we will need to cleanup after successful conversion as well

Signed-off-by: Andrea Waltlova <[email protected]>
@andywaltlova andywaltlova requested a review from r0x0d November 23, 2023 11:23
scripts/conversion_script.py Outdated Show resolved Hide resolved
Signed-off-by: Andrea Waltlova <[email protected]>
@r0x0d
Copy link
Member

r0x0d commented Nov 27, 2023

We can fix the pre-commit errors in a following pr.

@r0x0d r0x0d merged commit 7b4994b into oamg:main Nov 27, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants