-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup c2r pkg correctly #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 351 382 +31
=========================================
+ Hits 351 382 +31 ☔ View full report in Codecov by Sentry. |
andywaltlova
force-pushed
the
fix/cleanup-c2r-pkg
branch
from
November 21, 2023 21:12
8b5a07f
to
9a97817
Compare
andywaltlova
commented
Nov 21, 2023
Signed-off-by: Andrea Waltlova <[email protected]>
andywaltlova
force-pushed
the
fix/cleanup-c2r-pkg
branch
from
November 23, 2023 11:12
c63008d
to
3c9169b
Compare
Once we are not reliant on the installed RPM for statistical purposes on insights we will need to cleanup after successful conversion as well Signed-off-by: Andrea Waltlova <[email protected]>
Signed-off-by: Andrea Waltlova <[email protected]>
andywaltlova
force-pushed
the
fix/cleanup-c2r-pkg
branch
from
November 23, 2023 11:20
c0f81a1
to
334cce2
Compare
for more information, see https://pre-commit.ci
andywaltlova
commented
Nov 23, 2023
r0x0d
reviewed
Nov 23, 2023
r0x0d
reviewed
Nov 23, 2023
Signed-off-by: Andrea Waltlova <[email protected]>
Signed-off-by: Andrea Waltlova <[email protected]>
for more information, see https://pre-commit.ci
andywaltlova
force-pushed
the
fix/cleanup-c2r-pkg
branch
from
November 24, 2023 11:18
6de2371
to
65e1b94
Compare
bocekm
approved these changes
Nov 24, 2023
r0x0d
reviewed
Nov 24, 2023
Signed-off-by: Andrea Waltlova <[email protected]>
Signed-off-by: Andrea Waltlova <[email protected]>
andywaltlova
force-pushed
the
fix/cleanup-c2r-pkg
branch
from
November 25, 2023 08:30
65e1b94
to
ddf185e
Compare
Signed-off-by: Andrea Waltlova <[email protected]>
for more information, see https://pre-commit.ci
r0x0d
approved these changes
Nov 27, 2023
We can fix the pre-commit errors in a following pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMS-3086