Replace some prints by log messages #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andywaltlova
commented
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 98.34% 96.26% -2.08%
==========================================
Files 1 1
Lines 302 348 +46
Branches 38 44 +6
==========================================
+ Hits 297 335 +38
- Misses 0 3 +3
- Partials 5 10 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
r0x0d
force-pushed
the
feat/logging-levels
branch
5 times, most recently
from
66fe039 to
178e1f8
Compare
andywaltlova
force-pushed
the
feat/logging-levels
branch
from
178e1f8 to
39d6dfd
Compare
andywaltlova
commented
Apr 16, 2024
Signed-off-by: Andrea Waltlova <[email protected]>
Now the logs will be written to the log file and also have a link to the sos report, so when it will be collected, we will have all the logs that were executed as well.
Signed-off-by: Andrea Waltlova <[email protected]>
andywaltlova
force-pushed
the
feat/logging-levels
branch
from
5733fda to
c74d419
Compare
Signed-off-by: Andrea Waltlova <[email protected]>
|
Adjusted few tests here and there to increase coverage, now just some lines in logging functions are missing |
r0x0d
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMS-3838
SSIA
rhcPass log level to executed script for more granular logging possibility rhc-worker-script#119Resolves: #49