Skip to content

Commit

Permalink
Make post-conversion analysis summary clearer (#1437)
Browse files Browse the repository at this point in the history
I was not sure what "No changes needed" means (changes to do by the
tool or myself?).
IMHO "No action required" is clearer.
  • Loading branch information
bocekm authored Dec 6, 2024
1 parent dbcd745 commit 9959824
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions convert2rhel/actions/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
#: When we print a report for the user to view, we want some explanation of
#: what the results mean
STATUS_HEADER = {
0: "Success (No changes needed)",
25: "Info (No changes needed)",
0: "Success (No action required)",
25: "Info (No action required)",
51: "Warning (Review and fix if needed)",
101: "Skip (Could not be checked due to other failures)",
152: "Overridable (Review and either fix or ignore the failure)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ def test_failures_and_skips_in_report(convert2rhel):
# Verify the ordering and contents
# of the skip and error header
# Success header first
c2r.expect_exact("Success (No changes needed)")
c2r.expect_exact("Success (No action required)")

# Info header
c2r.expect_exact("Info (No changes needed)")
c2r.expect_exact("Info (No action required)")

# Warning header
c2r.expect_exact("Warning (Review and fix if needed)")
Expand Down Expand Up @@ -119,7 +119,7 @@ def test_successful_report(convert2rhel):

# Verify that only success header printed out, assert if error or skip header appears
c2r_report_header_index = c2r.expect(
["No changes needed", "Must fix before conversion", "Could not be checked due to other failures"],
["No action required", "Must fix before conversion", "Could not be checked due to other failures"],
timeout=300,
)
if c2r_report_header_index == 0:
Expand Down Expand Up @@ -168,7 +168,7 @@ def test_convert_method_successful_report(convert2rhel):

# Verify that none of the headers is present, assert if it is present
c2r_report_header_index = c2r.expect(
[EOF, "No changes needed", "Must fix before conversion", "Could not be checked due to other failures"],
[EOF, "No action required", "Must fix before conversion", "Could not be checked due to other failures"],
timeout=300,
)
if c2r_report_header_index == 0:
Expand Down

0 comments on commit 9959824

Please sign in to comment.