Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHELC-1105] Try using SCA enabled account in tests #1186

Merged
merged 3 commits into from
Sep 3, 2024
Merged

[RHELC-1105] Try using SCA enabled account in tests #1186

merged 3 commits into from
Sep 3, 2024

Conversation

danmyway
Copy link
Member

@danmyway danmyway commented Apr 22, 2024 •
edited
Loading

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@danmyway danmyway added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. labels Apr 22, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (e49fda3) to head (034e649).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files          66       66           
  Lines        4997     4997           
  Branches      877      877           
=======================================
  Hits         4819     4819           
  Misses        101      101           
  Partials       77       77
Flag Coverage Δ
centos-linux-7 91.86% <ø> (ø)
centos-linux-8 92.75% <ø> (ø)
centos-linux-9 92.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@has-bot
Copy link
Member

has-bot commented Apr 22, 2024

This PR does not require integration tests to be run.

Comment generated by an automation.

@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit build

@danmyway
Copy link
Member Author

/packit test

@danmyway danmyway changed the title Try using SCA enabled account in tests [RHELC-1105] Try using SCA enabled account in tests Apr 29, 2024
@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit test

@danmyway danmyway force-pushed the try-sca-enabled branch 2 times, most recently from ea0487a to 0bd4158 Compare August 29, 2024 14:35
@danmyway
Copy link
Member Author

/packit test

@danmyway
Copy link
Member Author

/packit test

1 similar comment
@danmyway
Copy link
Member Author

/packit test

@kokesak
Copy link
Member

kokesak commented Sep 2, 2024

/packit build

@kokesak kokesak added tests/all Run the full test suite. Equivalent to `/packit test`. and removed tests/skip This PR does not require integration tests to be run. labels Sep 2, 2024
@has-bot
Copy link
Member

has-bot commented Sep 2, 2024

/packit test

Comment generated by an automation.

@danmyway
Copy link
Member Author

danmyway commented Sep 2, 2024

/packit test

@danmyway
Copy link
Member Author

danmyway commented Sep 3, 2024

/packit test

@danmyway danmyway marked this pull request as ready for review September 3, 2024 07:22
@danmyway danmyway requested a review from a team as a code owner September 3, 2024 07:22
@danmyway danmyway requested a review from SerCantus September 3, 2024 07:22
kokesak
kokesak approved these changes Sep 3, 2024
View reviewed changes
plans/tier1.fmf
when: distro == alma-8-latest, alma-9-latest, rocky-8.8
because: |
An unhandled UnicodeDecodeError breaks the conversion.
Reference https://issues.redhat.com/browse/RHELC-1711
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reference!

@kokesak
Copy link
Member

kokesak commented Sep 3, 2024

@danmyway danmyway merged commit 2a0ed40 into oamg:main Sep 3, 2024
66 checks passed
@danmyway danmyway removed the request for review from SerCantus September 3, 2024 07:45
@danmyway danmyway deleted the try-sca-enabled branch September 3, 2024 08:22
@danmyway danmyway mentioned this pull request Sep 3, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokesak kokesak kokesak approved these changes

Assignees
No one assigned
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/all Run the full test suite. Equivalent to `/packit test`.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danmyway @has-bot @kokesak