fix(add_upgrade_boot_entry): convert arg list into a tuple

Convert collected rd.lvm args into a tuple before trying to make a set with one of the elements being the args. As list is not hashable, this causes the actor to crash.
oamg · Dec 16, 2024 · c7ceb0d · c7ceb0d
1 parent 3c3421a
commit c7ceb0d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/repos/system_upgrade/common/actors/addupgradebootentry/libraries/addupgradebootentry.py b/repos/system_upgrade/common/actors/addupgradebootentry/libraries/addupgradebootentry.py
@@ -303,7 +303,7 @@ def _get_rdlvm_arg_values():
     api.current_logger().debug('Collected the following rd.lvm.lv args that are undesired for the squashfs: %s',
                                rd_lvm_values)
 
-    return rd_lvm_values
+    return tuple(rd_lvm_values)
 
 
 def construct_cmdline_args_for_livemode():

diff --git a/...s/system_upgrade/common/actors/addupgradebootentry/tests/unit_test_addupgradebootentry.py b/...s/system_upgrade/common/actors/addupgradebootentry/tests/unit_test_addupgradebootentry.py
@@ -273,7 +273,7 @@ def test_get_rdlvm_arg_values(monkeypatch):
 
     args = addupgradebootentry._get_rdlvm_arg_values()
 
-    assert args == ['A', 'B']
+    assert tuple(args) == ('A', 'B')
 
 
 def test_get_device_uuid(monkeypatch):