Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix _copy_decouple() for relative symlinks #1158

Closed
wants to merge 2 commits into from
Closed

[WIP] Fix _copy_decouple() for relative symlinks #1158

wants to merge 2 commits into from

Conversation

abadger
Copy link
Member

@abadger abadger commented Jan 9, 2024 •
edited
Loading

It was found in testing that absolute symlinks in /etc/pki are being preserved correctly but relative symlinks are causing a traceback. This PR will fix that.

Right now this is just additional unittests for the desired behaviour:

  • Add some unittests that test symlink handling of copy_decouple with relative symlinks.
  • Enhance the temporary_directory fixture to handle creation of relative symlinks too.

If anyone has additional scenarios that they think should work feel free to add to the PR or mention them to me and I'll make a test for it.

@abadger
New, failing unittests for correct symlink decoupling behaviour.
80c01aa 
* Add some unittests that test symlink handling of copy_decouple with relative symlinks.
* Enhance the temporary_directory fixture to handle creation of relative symlinks too.
@abadger abadger marked this pull request as draft January 9, 2024 22:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.9to9.3,kernel-rt-8.9to9.3 to schedule kernel-rt and beaker-minimal test sets for 8.9->9.3 upgrade path

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 added the bug Something isn't working label Jan 10, 2024
@pirat89 pirat89 added this to the 8.10/9.4 milestone Jan 10, 2024
@abadger
Rework _copy_decouple to follow relative symlinks and symlinks to dir…
8059406 
…ectories.

The previous code handled absolute symlinks fine but when there were relative symlinks it would
traceback.  Additionally, it did not handle symlinks to directories that occurred outside of
/etc/pki.  This should fix both of those.
@abadger
Copy link
Member Author

abadger commented Jan 11, 2024

I pushed the branch to oamg/leapp-repository by mistake (instead of abadger/leapp-repository). Closing this in favor of: #1160

@abadger abadger closed this Jan 11, 2024
@pirat89 pirat89 deleted the fix-relative-symlink-issue branch September 4, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
8.10/9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@abadger @pirat89